add strong-error-handler template - #276
Conversation
|
Hey @loay, your pull requests configures loopback-workspace REST API to use the new error handler, but does not modify the actual templates. Because loopback-workspace is never really run in a production mode, the changes you made so far can be reverted. You need to modify these files instead:
|
|
|
||
| // The ultimate error handler. | ||
| app.use(loopback.errorHandler()); | ||
| app.use(loopback.strongErrorHandler()); |
There was a problem hiding this comment.
This is weird, apparently the person upgrading this project added JSON files but forgot to change server/server.js to match the new template. Let's revert all changes outside templates to keep this PR focused.
|
Looks better. As I said, we should load the new module directly and don't depend on loopback deps. In which case you need to modify https://github.com/strongloop/loopback-workspace/blob/bcb1dc85e3e3d2fcc986ff94e2f4684861c6f3f6/templates/projects/empty-server/data.js to include the new dependency. |
2 participants
No description provided.